Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(session replay): add version option into local config generation #886

Merged
merged 2 commits into from
Sep 23, 2024
Merged

fix(session replay): add version option into local config generation #886

merged 2 commits into from
Sep 23, 2024

Conversation

jxiwang
Copy link

@jxiwang jxiwang commented Sep 23, 2024 •
edited
Loading

Summary

Fixes issue where the library wasn't propagating to the track call header.

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?:

@jxiwang jxiwang marked this pull request as ready for review September 23, 2024 14:27
lewgordon-amplitude
lewgordon-amplitude approved these changes Sep 23, 2024
View reviewed changes
Copy link

@lewgordon-amplitude lewgordon-amplitude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'm thinking we should fix the typing in the future so that the version is enforced somewhat.

@jxiwang jxiwang merged commit 77e720d into v1.x Sep 23, 2024
3 checks passed
@jxiwang jxiwang deleted the AMP-109514 branch September 23, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mercy811 Mercy811 Mercy811 left review comments

@izaaz izaaz izaaz left review comments

@lewgordon-amplitude lewgordon-amplitude lewgordon-amplitude approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jxiwang @izaaz @Mercy811 @lewgordon-amplitude